Wire branch completion into git diff argument positions#228
Merged
Conversation
Add local_branches and remote_branches generators to git diff's args, so that branch names appear in the completions dropdown alongside commits and changed files. Closes APP-3484 Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
APP-3484 [git] Wire branch completion into git diff argument positions
Wire branch completion generators ( See GitHub #3805 |
Contributor
Author
|
Screenshot: |
This reverts commit 5c04efb.
vkodithala
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire
local_branchesandremote_branchesgenerators intogit diffargument positions. Previously,git diffonly suggested commits and changed/tracked files. Now it also suggests local and remote branch names in the completions dropdown.Closes APP-3484
See also: GitHub #3805
What changed
In
command-signatures/json/git.json, addedlocal_branchesandremote_branchesto thegit diffsubcommand'sargs.generatorNamearray:Before:
After:
No new generators were needed — both
local_branchesandremote_branchesalready exist ingit.rsand are used by other subcommands likecheckout,log, andmerge.Screenshots
git diffcompletions showing branches, commits, and changed files:Conversation: https://staging.warp.dev/conversation/59758e67-03de-4ee3-b373-95bd8525be0d
Run: https://oz.staging.warp.dev/runs/019d4b03-015d-70cf-91b9-a644040c6da9
This PR was generated with Oz.